Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comm_info_request content to conform to spec in a backwards-compatible way #6949

Merged
merged 2 commits into from Aug 6, 2019

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 5, 2019

References

Fixes #6947

Code changes

Adds the comm info target_name content attribute, and a workaround making target_name be set from the incorrect target if it makes sense.

This workaround should be removed in services 5.0.

User-facing changes

Backwards-incompatible changes

None. It does deprecate the target attribute, to be removed in services 5 (jlab 2).

…tible way.

This workaround should be removed in services 5.0.

Fixes jupyterlab#6947
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Aug 5, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 1.1 milestone Aug 5, 2019
@jasongrout jasongrout requested a review from blink1073 Aug 6, 2019
Copy link
Member

@blink1073 blink1073 left a comment

LGTM, thanks!

@blink1073 blink1073 merged commit f2d664b into jupyterlab:master Aug 6, 2019
9 checks passed
@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 6, 2019

@meeseeksbot, backport to 1.0.x

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 6, 2019

@meeseeksdev, backport to 1.0.x

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 6, 2019

@meeseeksdev hello

@meeseeksdev
Copy link

@meeseeksdev meeseeksdev bot commented Aug 6, 2019

Look at me, @blink1073, I'm Mr. Meeseeks!

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 6, 2019

@meeseeksdev backport to 1.0.x

@mlucool
Copy link
Contributor

@mlucool mlucool commented Aug 9, 2019

@blink1073, when do you expect to release a 1.0.x version with this patch?

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Aug 9, 2019

We can try to do one today. We'd be testing out a new system for releasing patch branches, so there might be delays, though.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 9, 2019

@jasongrout, happy to block out a time this afternoon to meet up.

blink1073 added a commit that referenced this issue Aug 9, 2019
blink1073 added a commit that referenced this issue Aug 9, 2019
…9-on-1.0.x

Backport PR #6949 on branch 1.0.x (Fix comm_info_request content to conform to spec in a backwards-compatible way)
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Aug 10, 2019

jlab 1.0.5 is out now on pypi with this bugfix.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 10, 2019

Thanks @jasongrout! 🎉

@lock lock bot locked as resolved and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants