Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail on deduplicate and ignore optional #7013

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 14, 2019

References

cf #6974

Code changes

Ignore optional deps and do not fail if there are any duplicate packages in yarn-dedupe.

User-facing changes

Less scary-looking messages about node-gyp.

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Aug 14, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Aug 14, 2019

@vidartf
Copy link
Member

@vidartf vidartf commented Aug 14, 2019

Xref previous ignore optional discussion here: #7003

The dedupe fix LGTM. Should the yarn.lock in staging be regenerated without the optional dependencies?

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Aug 16, 2019

Sounds good. My dev setup is currently broken. I'm going to spend this morning putting Linux on my laptop.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Aug 16, 2019

Let's save the manual dedupe for a follow-up, so we can backport this.

@blink1073 blink1073 merged commit 98f1a9a into jupyterlab:master Aug 16, 2019
7 of 9 checks passed
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Aug 16, 2019

@meeseeksdev backport to 1.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Aug 16, 2019
blink1073 added a commit that referenced this issue Aug 16, 2019
…3-on-1.0.x

Backport PR #7013 on branch 1.0.x (Do not fail on deduplicate and ignore optional)
@lock lock bot locked as resolved and limited conversation to collaborators Sep 15, 2019
@blink1073 blink1073 deleted the build-options branch Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants