Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build source maps for releases. #7150

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 3, 2019

If we build them, the browser tries to fetch them and gets a 404 since we do not package them.

References

Follow-up to #7136

CC @vidartf who had some thoughts about source map files being shipped. I think it is fine not to ship source map files and ask people who need them to do jupyter lab build which will build them and put them in place.

Code changes

In #7136, we eliminate source map files from our pypi and conda-forge packages. However, we still build the source maps, so the browser still attempts to get them, and gets a 404 for the source map.

This goes all the way and stops building source maps for releases.

In theory we could remove some of the packaging code in #7136, but it is also provides a good fail-safe against include map files, so might as well leave it in?

User-facing changes

The user will not see a 404 for source map files in --core-mode like in 1.2.0a0.

Backwards-incompatible changes

None

@jasongrout jasongrout added this to the 1.2 milestone Sep 3, 2019
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Sep 3, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

If we build them, the browser tries to fetch them and gets a 404 since we do not package them.
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Sep 3, 2019

Ready for review

vidartf
vidartf approved these changes Sep 4, 2019
Copy link
Member

@vidartf vidartf left a comment

My thought was that sourcemaps is helpful for users debugging lab and submitting error reports. I don't know if we're really seeing that effect though. So let's give this a go, and then if we start getting error reports that are hard to debug without the sourcemaps, we can reconsider.

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Sep 4, 2019

Thanks @vidartf!

@jasongrout jasongrout merged commit 6bbe1a1 into jupyterlab:master Sep 4, 2019
9 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants