Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for renders for nbformat.IError to be created #7203

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@mlucool
Copy link
Contributor

@mlucool mlucool commented Sep 13, 2019

References

Fixes #7193

Code changes

Adds a mime type which gives developers access to the raw nbformat IError data via a new mime type. This is backwards compatible and allows for an error render to be built.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Sep 13, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 16, 2019

LGTM, thanks!

@blink1073 blink1073 merged commit 8eb3df9 into jupyterlab:master Sep 16, 2019
9 checks passed
@blink1073 blink1073 added this to the 1.2 milestone Sep 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants