Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overwriting of target attribute of anchors rendered by IPython.display #7215

Conversation

kavishdahekar
Copy link

@kavishdahekar kavishdahekar commented Sep 16, 2019

Bug fix for issue where user provided value for target attribute of anchor tags rendered by IPython.display were overwritten by '_blank' or '_self'.

References

Fixes #6827

Code changes

The bugfix will overwrite the target attribute only if it was not set.
Setting of the rel attribute to noopener moved to separate if block.

User-facing changes

Users rendering anchor elements using IPython.display will be able to set custom values for "target" attribute.

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Sep 16, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@kavishdahekar kavishdahekar changed the title Fixes jupyterlab#6827 Fixes overwriting of target attribute of anchors rendered by IPython.display Sep 16, 2019
@kavishdahekar kavishdahekar changed the title Fixes overwriting of target attribute of anchors rendered by IPython.display Fix overwriting of target attribute of anchors rendered by IPython.display Sep 16, 2019
Copy link
Member

@blink1073 blink1073 left a comment

LGTM, thanks! The CI failure looks unrelated, so I kicked it.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 16, 2019

Thanks again @kavishdahekar, and congratulations on your first JupyterLab PR!

@blink1073 blink1073 merged commit 30be9f7 into jupyterlab:master Sep 16, 2019
9 checks passed
@kavishdahekar
Copy link
Author

@kavishdahekar kavishdahekar commented Sep 17, 2019

Thanks @blink1073 :) Looking forward to contributing more to the project.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 18, 2019

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Sep 18, 2019
jasongrout added a commit that referenced this issue Sep 18, 2019
…5-on-1.x

Backport PR #7215 on branch 1.x (Fix overwriting of target attribute of anchors rendered by IPython.display)
@jasongrout jasongrout removed this from the 1.2 milestone Oct 11, 2019
@jasongrout jasongrout added this to the 2.0 milestone Oct 11, 2019
@lock lock bot added the status:resolved-locked label Nov 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement pkg:rendermime status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants