Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PageConfig.Extension #7216

Merged
merged 1 commit into from Sep 16, 2019
Merged

Add PageConfig.Extension #7216

merged 1 commit into from Sep 16, 2019

Conversation

@afshin
Copy link
Member

@afshin afshin commented Sep 16, 2019

Creates a PageConfig.Extension namespace that exports isDeferred and isDisabled methods.

References

This PR is a prerequisite for #7147.

A new minor version of @jupyterlab/coreutils will need to be published after this PR is accepted before #7147 will pass CI.

Code changes

Creates a PageConfig.Extension namespace that exports isDeferred and isDisabled methods.

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Sep 16, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

@blink1073 blink1073 commented Sep 16, 2019

LGTM, thanks!

@blink1073 blink1073 merged commit 15d0c23 into jupyterlab:master Sep 16, 2019
9 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants