Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernelspec metadata #7229

Merged
merged 3 commits into from Sep 18, 2019
Merged

Add kernelspec metadata #7229

merged 3 commits into from Sep 18, 2019

Conversation

declanvk
Copy link
Contributor

@declanvk declanvk commented Sep 18, 2019

References

This closes #7228 based on the proposed actions.

Code changes

Added metadata field to ISpecModel and validation code. Added env field to validation code.

User-facing changes

This enables extension developers to coordinate easily with a back-end application that store information in the kernelspec metadata.

Backwards-incompatible changes

None

@dleen @blink1073

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Sep 18, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@declanvk declanvk changed the title Kernelspec metadata Add kernelspec metadata Sep 18, 2019
dleen
dleen approved these changes Sep 18, 2019
Copy link

@dleen dleen left a comment

Looks good to me!

Copy link
Member

@blink1073 blink1073 left a comment

Looks great, thanks!

@blink1073 blink1073 added this to the 1.2 milestone Sep 18, 2019
@blink1073 blink1073 merged commit c400c92 into jupyterlab:master Sep 18, 2019
9 checks passed
@declanvk declanvk deleted the kernelspec-metadata branch Sep 18, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Sep 18, 2019

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Sep 18, 2019
jasongrout added a commit that referenced this issue Sep 18, 2019
…9-on-1.x

Backport PR #7229 on branch 1.x (Add kernelspec metadata)
@jasongrout jasongrout removed this from the 1.2 milestone Oct 11, 2019
@jasongrout jasongrout added this to the 2.0 milestone Oct 11, 2019
@lock lock bot added the status:resolved-locked label Nov 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement pkg:services status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants