Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment when using custom yarn registry #7249

Merged
merged 1 commit into from Oct 1, 2019
Merged

Add comment when using custom yarn registry #7249

merged 1 commit into from Oct 1, 2019

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Sep 20, 2019

References

Fixes #7248 (follow-up of #7109)

Code changes

NA

User-facing changes

NA

Backwards-incompatible changes

NA

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Sep 20, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@fcollonval
Copy link
Member Author

@fcollonval fcollonval commented Sep 20, 2019

@vidartf is this understandable?

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 added this to the 1.2 milestone Oct 1, 2019
@blink1073 blink1073 merged commit d240047 into master Oct 1, 2019
9 checks passed
@jasongrout jasongrout removed this from the 1.2 milestone Oct 11, 2019
@jasongrout jasongrout added this to the 2.0 milestone Oct 11, 2019
@telamonian
Copy link
Member

@telamonian telamonian commented Oct 15, 2019

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Oct 15, 2019
blink1073 added a commit that referenced this issue Oct 15, 2019
…9-on-1.x

Backport PR #7249 on branch 1.x (Add comment when using custom yarn registry)
@vidartf vidartf deleted the fix-7248 branch Oct 15, 2019
@lock lock bot added the status:resolved-locked label Nov 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants