Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply all options to initial jlab instance #7251

Merged

Conversation

meinstein
Copy link

@meinstein meinstein commented Sep 20, 2019

References

Issue:
#6400

Relevant past commits:
39ccbc9
9b2e915

Code changes

When instantiating JupyterLab, the full options object is passed up to the superclass. Previously, only the shell seemed to be.

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Sep 20, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@meinstein meinstein changed the title apply options to initial instance apply all options to initial jlab instance Sep 20, 2019
@blink1073 blink1073 added this to the 1.2 milestone Sep 20, 2019
Copy link
Member

@blink1073 blink1073 left a comment

LGTM, thanks @meinstein!

@blink1073 blink1073 merged commit d427440 into jupyterlab:master Sep 20, 2019
9 checks passed
@jasongrout jasongrout removed this from the 1.2 milestone Oct 11, 2019
@jasongrout jasongrout added this to the 2.0 milestone Oct 11, 2019
@meinstein
Copy link
Author

@meinstein meinstein commented Nov 8, 2019

Hi @jasongrout! I noticed that you added this PR to the 1.2 milestone. I don't see it as of 1.2.2. Is there a particular version of 1.2.x where we can expect this patch to land? Many thanks.

@lock lock bot added the status:resolved-locked label Dec 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement pkg:application status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants