Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #7264: use default app_dir when app_dir == '' #7268

Merged
merged 1 commit into from Sep 27, 2019

Conversation

telamonian
Copy link
Member

@telamonian telamonian commented Sep 26, 2019

References

fixes #7264

Code changes

Ensures that the default value of app_dir is used when app_dir == ''

User-facing changes

Extensions will install correctly, instead of lab assets building in an extension dir

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Sep 26, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@telamonian
Copy link
Member Author

@telamonian telamonian commented Sep 26, 2019

@vidartf You're the one who set up all of the AppOptions stuff, right? Does this fix look reasonable to you?

Copy link
Member

@vidartf vidartf left a comment

Looks like the right fix to me. For reference, the '' value seems to mostly come from the BaseExtensionApp default.

@telamonian
Copy link
Member Author

@telamonian telamonian commented Sep 27, 2019

The remaining test failure is just that NASA link in the docs, so I'll merge this

@telamonian telamonian merged commit 457223a into jupyterlab:master Sep 27, 2019
7 of 9 checks passed
@telamonian telamonian added this to the 2.0 milestone Sep 27, 2019
@telamonian
Copy link
Member Author

@telamonian telamonian commented Sep 27, 2019

@blink1073 @vidartf Does this need to get backported?

@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 3, 2019

@jasongrout, did you include #7079 in the 1.x branch? If not, not further action is required. If so, this needs to be backported to 1.x.

@telamonian
Copy link
Member Author

@telamonian telamonian commented Oct 15, 2019

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Oct 15, 2019
telamonian added a commit that referenced this issue Oct 15, 2019
…8-on-1.x

Backport PR #7268 on branch 1.x (fixes #7264: use default `app_dir` when `app_dir == ''`)
@lock lock bot added the status:resolved-locked label Nov 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants