Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip custom click behavior on links when the download attribute is set #7311

Merged
merged 1 commit into from Oct 11, 2019

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Oct 10, 2019

References

Fixes #5443

Code changes

User-facing changes

The presumption here is that if an anchor node has a download attribute explicitly set, the user really does want to download the file rather than opening the file in JLab.

Backwards-incompatible changes

None - perhaps this should be backported to 1.2?

An incompatible change we probably should do in the future is tighten up the linkHandler signature to insist that the node is an anchor node.

The presumption here is that if an A node has a download attribute explicitly set, the user really does want to download the file rather than opening the file in JLab.

Fixes jupyterlab#5443
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Oct 10, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 1.2 milestone Oct 10, 2019
@jasongrout jasongrout modified the milestones: 1.2, 2.0 Oct 10, 2019
@jasongrout jasongrout added the tag:Backport This PR is slated to be backported after it is merged. label Oct 10, 2019
Copy link
Member

@blink1073 blink1073 left a comment

LGTM!

@jasongrout jasongrout merged commit 3e2914a into jupyterlab:master Oct 11, 2019
9 checks passed
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Oct 11, 2019

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Oct 11, 2019
jasongrout added a commit that referenced this issue Oct 11, 2019
…1-on-1.x

Backport PR #7311 on branch 1.x (Skip custom click behavior on links when the download attribute is set)
@jasongrout jasongrout removed the tag:Backport This PR is slated to be backported after it is merged. label Oct 12, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Nov 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Backwards compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants