Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update marked to 0.7.0 #7326

Merged
merged 1 commit into from Oct 11, 2019
Merged

Update marked to 0.7.0 #7326

merged 1 commit into from Oct 11, 2019

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Oct 11, 2019

References

Fixes #6479

Code changes

Upgrade marked.js to 0.7.0

User-facing changes

Some markdown bugs and security issues are fixed.

Backwards-incompatible changes

Based on #6479 (comment) and looking again at the marked.js 0.7.0 release notes, I think this is backwards compatible for our purposes. We're not using the options that make their release not backwards compatible, IIRC.

@jasongrout jasongrout added the tag:Backport label Oct 11, 2019
@jasongrout jasongrout added this to the 2.0 milestone Oct 11, 2019
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Oct 11, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout requested a review from blink1073 Oct 11, 2019
Copy link
Member

@blink1073 blink1073 left a comment

👍🏼

@jasongrout jasongrout merged commit e04e3af into jupyterlab:master Oct 11, 2019
7 of 9 checks passed
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Oct 11, 2019

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Oct 11, 2019
jasongrout added a commit that referenced this issue Oct 11, 2019
…6-on-1.x

Backport PR #7326 on branch 1.x (Update marked to 0.7.0)
@jasongrout jasongrout removed the tag:Backport label Oct 12, 2019
@lock lock bot added the status:resolved-locked label Nov 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants