Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset log display and count when non-notebook tab gets activated #7334

Merged
merged 1 commit into from Oct 12, 2019

Conversation

mbektas
Copy link
Member

@mbektas mbektas commented Oct 12, 2019

fixes #7325

Detects if new tab that is made current is not notebook and in that case, resets the log display and log counts.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Oct 12, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Oct 12, 2019

This looks and works great; thanks!

@jasongrout jasongrout merged commit d62af0f into jupyterlab:master Oct 12, 2019
9 checks passed
@jasongrout jasongrout added this to the 2.0 milestone Oct 12, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Oct 12, 2019

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Oct 12, 2019
jasongrout added a commit that referenced this issue Oct 12, 2019
…4-on-1.x

Backport PR #7334 on branch 1.x (reset log display and count when non-notebook tab gets activated)
@lock lock bot added the status:resolved-locked label Nov 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:logconsole status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants