Clean up log console api a bit #7379
This cleans up the api for the log console a bit to conform to conventions we've used elsewhere in the code, such as:
and many more.
Only in an unreleased package
The text was updated successfully, but these errors were encountered:
…ily. This also lets us set up keyboard shortcuts for the buttons, etc.
Would you mind looking at the last two commits as well? I simplified the status bar components, and switched the highlight colors to the brand colors.
It seems that it is really hard to highlight something in the status bar because the status bar does not use straight CSS, so you don't get good CSS inheritance.
…ary code. There are some subtle issues fixed here. 1. LogConsolePanel is now more careful and complete in emitting sourceDisplayed signal so that we don’t have to have a message hook anymore. 2. Because we more carefully account for displayed messages, we remove the flashEnabled checks in the status bar updates, which makes the flashing work more correctly. For example, with flashing enabled, now we will see the indicator flash when the console is open but not visible (for example, it may be hidden behind another tab).
Okay, I think this is good to go now. I left in the notebook output logging so it is easy to test, but we can remove that before merging.
@blink1073 - Would you rather we added a setting somewhere for the notebook to log all output to the log console (default to off)? I think we don't need it for now, but you feel it is really needed, we can add it.
Owee, I'm MrMeeseeks, Look at me.
There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones.
Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!
If these instruction are inaccurate, feel free to suggest an improvement.