Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine log console message UX #7448

Merged
merged 4 commits into from Nov 1, 2019
Merged

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Oct 31, 2019

References

Fixes #7444 and appears to also fix #7443

Code changes

  • Introduces a protected output function to determine when messages should be collapsed, and uses it to collapse messages less aggressively. In particular, we only collapse messages that are in the same timestamp second (so that the timestamp at second resolution is accurate).
  • Change the title of the log console prompt nodes to include the full date.
  • Change the status bar indicator to indicate number of incoming messages that have not been displayed, rather than total number of (possibly collapsed) log entries. This gives the user more relevant information ("How much new stuff is there" instead of "how much stuff is there total")

User-facing changes

logs

Backwards-incompatible changes

I don't think there are any backwards incompatible changes. The one function signature that changes is a private function to the module.

jasongrout added 4 commits Oct 31, 2019
… log entries.

This makes it clearer when new things are coming in, and gives a sense for how many new things.
…ould be combined.

This allows subclasses of output area to define their own collapsing semantics, which may be less aggressive than the default output area behavior.
…ch is the resolution for our timestamp).

This means that visually, we are telling the truth with the timestamp - every message displayed with that time is the same time, to the resolution of the display (which is one second).
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Oct 31, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Oct 31, 2019

@ivanov - does this address most of your concerns?

@mbektasbbg - does this also address some of the thoughts you had regarding how log messages are treated and displayed?

@jasongrout jasongrout added this to the 1.2 milestone Oct 31, 2019
@mbektas
Copy link
Member

@mbektas mbektas commented Oct 31, 2019

thanks @jasongrout this looks great to me. I can still reproduce #7443 with these changes though.

@jasongrout jasongrout added the tag:Backport label Nov 1, 2019
@jasongrout jasongrout removed this from the 1.2 milestone Nov 1, 2019
@jasongrout jasongrout added this to the 2.0 milestone Nov 1, 2019
@mbektas
Copy link
Member

@mbektas mbektas commented Nov 1, 2019

@jasongrout I tested again and I am no longer able to reproduce #7443 . Looks good to me.

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Nov 1, 2019

Thanks!

@jasongrout jasongrout merged commit c27318d into jupyterlab:master Nov 1, 2019
6 of 9 checks passed
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Nov 1, 2019

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Nov 1, 2019
jasongrout added a commit that referenced this issue Nov 1, 2019
…8-on-1.x

Backport PR #7448 on branch 1.x (Refine log console message UX)
@jasongrout jasongrout removed the tag:Backport label Nov 1, 2019
@lock lock bot added the status:resolved-locked label Dec 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:logconsole status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants