Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure label is linked to a control when checking for element type #7458

Merged
merged 2 commits into from Dec 12, 2019

Conversation

mbektas
Copy link
Member

@mbektas mbektas commented Nov 1, 2019

This is an enhancement to a669392 making sure the label is actually linked to another control.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Nov 1, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

// that is linked with `for` attribute, so let it be.
if (
event.target instanceof HTMLLabelElement &&
this.node.querySelector(`#${event.target.getAttribute('for')}`)
Copy link
Contributor

@jasongrout jasongrout Nov 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add && event.target.getAttribute('for') to check if it is undefined?

@blink1073 blink1073 added this to the 2.0 milestone Dec 12, 2019
Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 7644983 into jupyterlab:master Dec 12, 2019
7 of 9 checks passed
@lock lock bot added the status:resolved-locked label Jan 11, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:apputils status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants