Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contribution Guide to require node v12+ #7479

Merged
merged 1 commit into from Nov 6, 2019

Conversation

austinbrian
Copy link
Contributor

@austinbrian austinbrian commented Nov 6, 2019

Installing the development branch runs into an issue if node version is
older than 12. This updates the CONTRIBUTING.md guide to ensure that
developers update the version.

References

Code changes

User-facing changes

Backwards-incompatible changes

Installing the development branch runs into an issue if node version is
older than 12.
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Nov 6, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit a09c3f6 into jupyterlab:master Nov 6, 2019
9 checks passed
@blink1073
Copy link
Member

@blink1073 blink1073 commented Nov 6, 2019

Congratulations on your first contribution @austinbrian!

@lock lock bot added the status:resolved-locked label Dec 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation enhancement status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants