Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added env prop to kernel options #7499

Merged
merged 1 commit into from Nov 9, 2019
Merged

Added env prop to kernel options #7499

merged 1 commit into from Nov 9, 2019

Conversation

borremosch
Copy link

@borremosch borremosch commented Nov 8, 2019

References

Fix for #7498

Code changes

Added property env to kernel options. env is added tothe request body.

User-facing changes

No user-facing changes

Backwards-incompatible changes

Fully backwards-compatible

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Nov 8, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Looks good to me, thanks!

@blink1073 blink1073 merged commit a441eb9 into jupyterlab:master Nov 9, 2019
9 checks passed
@blink1073
Copy link
Member

@blink1073 blink1073 commented Nov 9, 2019

Congrats on your first contribution!

@blink1073 blink1073 added this to the 2.0 milestone Nov 9, 2019
@lock lock bot added the status:resolved-locked label Dec 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement pkg:services status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants