Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dropdown option style issue in Windows #7513

Merged
merged 1 commit into from Nov 12, 2019

Conversation

mbektas
Copy link
Member

@mbektas mbektas commented Nov 12, 2019

This fixes an issue in Windows which can be reproduced by clicking cell type dropdown on notebook toolbar. If you move mouse out of option list then its style resets. This problem makes options not legible in dark theme.

before
OptionStyleBefore

after
OptionStyleAfter

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Nov 12, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Nov 12, 2019

Thank you! I'm cutting a patch release today, and we can get this in too.

@jasongrout jasongrout added this to the 2.0 milestone Nov 12, 2019
@jasongrout jasongrout merged commit a060dd5 into jupyterlab:master Nov 12, 2019
7 of 9 checks passed
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Nov 12, 2019

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Nov 12, 2019
jasongrout added a commit that referenced this issue Nov 12, 2019
…3-on-1.x

Backport PR #7513 on branch 1.x (fix dropdown option style issue in Windows)
@lock lock bot added the status:resolved-locked label Dec 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants