Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UseSignal example to the docs #7519

Merged
merged 1 commit into from Nov 15, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 12, 2019

References

Follow-up for #7501.

As mentioned in this comment, an embedded example for UseSignal would be useful.

The one provided in this PR might be a little bit long, so I'm also happy to change it and keep it more minimal if needed.

Code changes

None

User-facing changes

  • Users: None
  • Developers: documentation update

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented Nov 12, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

blink1073 commented Nov 15, 2019

LGTM, thank you!

@blink1073 blink1073 added this to the 2.0 milestone Nov 15, 2019
@blink1073 blink1073 merged commit c1e212c into jupyterlab:master Nov 15, 2019
@jtpio jtpio deleted the usesignal-example branch Nov 15, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Dec 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants