Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a better command palette icon #7577

Merged
merged 2 commits into from Dec 5, 2019
Merged

Added a better command palette icon #7577

merged 2 commits into from Dec 5, 2019

Conversation

tgeorgeux
Copy link
Contributor

@tgeorgeux tgeorgeux commented Dec 2, 2019

References

Closes #7038

Code changes

None (Added a new Icon)

User-facing changes

Adds a better Icon for the Command Palette

Screen Shot 2019-12-02 at 4 50 56 PM

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 2, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 3, 2019

cc @ellisonbg

@blink1073 blink1073 added this to the 2.0 milestone Dec 3, 2019
Copy link
Member

@blink1073 blink1073 left a comment

Looks good, thanks!

@afshin afshin merged commit 9c25950 into jupyterlab:master Dec 5, 2019
10 checks passed
@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Dec 10, 2019

Screen Shot 2019-12-10 at 12 03 37 PM

@tgeorgeux I think it needs a transparent background?

@lock lock bot added the status:resolved-locked label Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement status:resolved-locked tag:Design and UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants