Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a global track timing setting #7578

Merged
merged 3 commits into from Dec 5, 2019

Conversation

mlucool
Copy link
Contributor

@mlucool mlucool commented Dec 3, 2019

Code changes

This allows for a global default of whether or not to record timing metadata into the notebook file or not.

User-facing changes

A notebook setting was added to allow user to opt into this change.

Backwards-incompatible changes

None.

This allows for a global default of whether or not to record
timing metadata into the notebook metadata.
@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented Dec 3, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@mlucool
Copy link
Contributor Author

mlucool commented Dec 3, 2019

cc @Madhu94

A few comments:

  1. I choose to default this new feature off, but I think it would be best to default this on
  2. I feel like the toggle notebook timing is not required anymore. I have left this in and they do not fight each other (the toggle gets preference), but it feels somewhat contrived as a notebook setting instead of a global setting.

I tired to inject this into the notebook metadata on creation at some point as well, but metadata is cleared after the notebook widget is assigned the model.

@saulshanabrook saulshanabrook self-requested a review Dec 3, 2019
@saulshanabrook
Copy link
Member

saulshanabrook commented Dec 4, 2019

Hey @mlucool thank you for implementing this. We (@tgeorgeux, @jasongrout, @ellisonbg) had a discussion about this feature and decided that it might be simpler to just remove the notebook level metadata and just use the global setting, defaulting to off.

If it is off and there is existing execution time, then it should delete the execution metadata key when a cell is executed.

@saulshanabrook
Copy link
Member

saulshanabrook commented Dec 4, 2019

@mlucool Lemme know if you want me to tackle this change.

@mlucool
Copy link
Contributor Author

mlucool commented Dec 4, 2019

Thanks @saulshanabrook for looking. Sure, you can remove the notebook level feature.

@saulshanabrook
Copy link
Member

saulshanabrook commented Dec 4, 2019

I removed the feature, originally added in #6864

@saulshanabrook saulshanabrook added this to the 2.0 milestone Dec 5, 2019
@saulshanabrook
Copy link
Member

saulshanabrook commented Dec 5, 2019

I tried this locally and it seems to work. @afshin took a look at it and didn't have any objections.

@saulshanabrook saulshanabrook merged commit 69dbd5a into jupyterlab:master Dec 5, 2019
@mlucool mlucool deleted the global-track-timing branch Dec 5, 2019
@saulshanabrook saulshanabrook removed their request for review Dec 5, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 4, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 4, 2020
@saulshanabrook saulshanabrook self-assigned this Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants