Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6734: --extensions, --settings, --static, --all flags for jupyter lab clean #7583

Merged
merged 3 commits into from Dec 5, 2019

Conversation

telamonian
Copy link
Member

@telamonian telamonian commented Dec 3, 2019

No description provided.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 3, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Can we please call these options at the end of the usage test, in order?

@telamonian
Copy link
Member Author

@telamonian telamonian commented Dec 5, 2019

Can we please call these options at the end of the usage test, in order?

Done! Or did you want to have just one call with all of the options:

jupyter lab clean --extensions --settings --static --all

?

@telamonian
Copy link
Member Author

@telamonian telamonian commented Dec 5, 2019

Now that I think about it, we may want special handling for the extensions dir. Anything that gets deleted from a user's app dir will get automatically restored upon jupyter lab build except for extensions (I think). If you delete extensions you have to reinstall each one of your extensions.

So maybe --all should delete everything but extensions, and then --nuke (or something) deletes all? I guess in that case --all would really be more like --more or --most

@blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 5, 2019

I think the options and the tests are fine as-is, we may want to add a not to all to warn you that you'd have to re-install extensions though.

@telamonian
Copy link
Member Author

@telamonian telamonian commented Dec 5, 2019

Alright. I won't get too theoretical about it, and I'll add that note

@blink1073 blink1073 added this to the 2.0 milestone Dec 5, 2019
Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 5e68c8a into jupyterlab:master Dec 5, 2019
10 checks passed
@lock lock bot added the status:resolved-locked label Jan 4, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked tag:Build System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants