Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionnaly force new browser tab #7603

Merged
merged 1 commit into from Dec 9, 2019

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Dec 7, 2019

References

Fix #7602

Code changes

Add an new optional argument 'newBrowserTab: boolean' to the arguments of 'help:open' command.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 7, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 added this to the 2.0 milestone Dec 9, 2019
@blink1073 blink1073 merged commit a1fc14a into jupyterlab:master Dec 9, 2019
10 checks passed
@lock lock bot added the status:resolved-locked label Jan 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2020
@fcollonval fcollonval deleted the force-browser-tab branch Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:help status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants