Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close output views on notebook closed #7633

Merged
merged 1 commit into from Dec 17, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Dec 16, 2019

References

Fixes #7301.

Code changes

Since content.model is disposed, its reference to the model would be set to null before accessing it and disconnect the signals handlers.

User-facing changes

Before

close-output-views-issue

After

close-output-views-fix

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 16, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit e16485e into jupyterlab:master Dec 17, 2019
10 checks passed
@jtpio jtpio deleted the close-output-views branch Dec 17, 2019
@jtpio jtpio added this to the 2.0 milestone Dec 18, 2019
@lock lock bot added the status:resolved-locked label Jan 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:notebook status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants