Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up less files #764

Merged
merged 2 commits into from Aug 26, 2016
Merged

Clean up less files #764

merged 2 commits into from Aug 26, 2016

Conversation

jasongrout
Copy link
Contributor

This (a) fixes an error in the build process that overwrote the generated css for me, and (b) adds some debugging notes to the less files. In particular, it notes rules that won't every apply, and the rule that causes #522.

@jasongrout
Copy link
Contributor Author

CC @ellisonbg - I'm not sure what to do about the less that doesn't apply, or the less rule that causes #522. We can merge this as-is and let you take it from here, or you can take these commits and make your own PR building on these. What do you think?

@jasongrout
Copy link
Contributor Author

It seems like the css file at https://github.com/jupyter/jupyterlab/blob/master/src/notebook/completion/index.css was only included because we manually included all css files at one point. @ellisonbg - this css file should probably be converted to less or included in a less file somewhere explicitly.

@ellisonbg
Copy link
Contributor

@jasongrout I am fine merging this PR as is. Could you open new issues about:

  • The index.css in the completion subpackage
  • General cleanup of the CodeMirror CSS

The thing that is weird is that classic notebook also has the 0.4em CSS stuff. I can look into that though in the cleanup.

@ellisonbg ellisonbg merged commit 88c5b1e into jupyterlab:master Aug 26, 2016
@jasongrout jasongrout deleted the notebookless branch December 17, 2016 03:17
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Browser Compatibility tag:Build System tag:Design and UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants