Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify user experience when selecting 'no kernel' for notebook #7647

Merged
merged 1 commit into from Dec 18, 2019

Conversation

lresende
Copy link
Member

@lresende lresende commented Dec 18, 2019

References

This change addresses the user experience described in #7646

Code changes

Simplify the user experience to select no kernel when opening a notebook that does not have a matching kernel available on the current environment.

User-facing changes

Original UI:
jupyterlab-select-notebook-kernel-no-kernel

Updated UI:
jupyterlab-select-notebook-kernel-updated

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 18, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 18, 2019

Thanks! I'll incorporate this into #7616

@blink1073 blink1073 merged commit 6461d0b into jupyterlab:master Dec 18, 2019
10 checks passed
@lresende
Copy link
Member Author

@lresende lresende commented Dec 18, 2019

@blink1073 Just saw that @tgeorgeux commented about the overlap with #7618. If we agree with the actual user experience changes, how should we proceed here ?

@lresende
Copy link
Member Author

@lresende lresende commented Dec 18, 2019

I guess you were quick, I see your comments on incorporating these changes.

@blink1073 blink1073 added this to the 2.0 milestone Jan 3, 2020
@lock lock bot added the status:resolved-locked label Feb 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants