Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vega4-extension #7650

Merged
merged 4 commits into from Dec 18, 2019
Merged

Remove vega4-extension #7650

merged 4 commits into from Dec 18, 2019

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 18, 2019

References

Fixes #7523

Code changes

Removes vega4-extension and updates vega5-extension to enable rendering vegalite-3 and vegalite-4 formats.

User-facing changes

Notebooks with vega output targeting older versions will render as pngs unless an additional vega4 extension is installed.

Backwards-incompatible changes

Drops direct support for rendering older vega formats.

@blink1073 blink1073 added this to the 2.0 milestone Dec 18, 2019
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 18, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@telamonian telamonian left a comment

LGTM!

},
"devDependencies": {
"@types/node": "^12.12.17",
Copy link
Member

@telamonian telamonian Dec 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blink1073 I was thinking through how to deal with this. Thanks for handling it!

I think there's an argument for getting rid of any explicit @types/node declaration, but I'll save that for another PR

@blink1073 blink1073 merged commit 828cb7c into jupyterlab:master Dec 18, 2019
10 checks passed
@lock lock bot added the status:resolved-locked label Jan 18, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
@blink1073 blink1073 deleted the remove-vega4 branch Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:vega status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants