Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollbar styles to nbconvert-css #7653

Merged
merged 1 commit into from Dec 18, 2019

Conversation

aschlaep
Copy link
Member

@aschlaep aschlaep commented Dec 18, 2019

Code changes

This adds the scrollbar style to the nbconvert-css package in order to export the scrollbar styling with all the rest.

User-facing changes

No user-facing changes that would affect JupyterLab users. Any user of the nbconvert-css stylesheet will be able to style their scrollbars if they set data-jp-theme-scrollbars="true".

Backwards-incompatible changes

None.

@aschlaep aschlaep requested a review from SylvainCorlay Dec 18, 2019
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 18, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 2.0 milestone Dec 18, 2019
Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit ffb05cc into jupyterlab:master Dec 18, 2019
10 checks passed
@lock lock bot added the status:resolved-locked label Jan 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants