New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Property Inspector #7665
Merged
Merged
Add a Property Inspector #7665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
75d88d9
to
78da7d3
Compare
jasongrout
approved these changes
Dec 23, 2019
Approving for the API changes - we can take up the UX issues in another PR after the beta. This does need a rebase before merging, though.
integrity finish property inspector lint integrity Strict null handling unused import Address review comments
afshin
reviewed
Dec 23, 2019
afshin
reviewed
Dec 23, 2019
afshin
reviewed
Dec 23, 2019
afshin
approved these changes
Dec 23, 2019
afshin
approved these changes
Dec 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
status:resolved-locked
Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
References
Fixes #7664
Code changes
Adds a
property-inspector
package and default implementation of the extension inapplication-extension
. The notebook extension is updated to use the inspector.User-facing changes
If no other extensions are installed that use the side panel, the use will always see the tool icon even when no notebooks are open, with the text "No properties to inspect.".
I attempted to only show the tab when one or more inspectors are registered, but it conflicts with our logic that allows side bar items to be moved to the opposite side.
Backwards-incompatible changes
None.