Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start new notebooks in edit mode #7666

Merged
merged 3 commits into from Dec 23, 2019
Merged

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 19, 2019

References

Fixes #6731

Code changes

Updates NotebookModel.initialize() to add an empty code cell if the model is empty.
This allows the logic for detecting an "empty" notebook to work on notebook opening.

User-facing changes

New notebooks now start in edit mode.

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 19, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 2.0 milestone Dec 19, 2019
Copy link
Contributor

@jasongrout jasongrout left a comment

Thanks!

@jasongrout jasongrout merged commit 5df09d7 into jupyterlab:master Dec 23, 2019
10 checks passed
@lock lock bot added the status:resolved-locked label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
@blink1073 blink1073 deleted the notebook-edit-mode branch Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:notebook status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants