Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands to move to next/prev tab bar in shell #7673

Merged
merged 1 commit into from Dec 30, 2019

Conversation

qntnrbns
Copy link
Contributor

@qntnrbns qntnrbns commented Dec 20, 2019

References

Fixing #7434, so that users can toggle between Tab Bars

Code changes

added activateNextTabBar and activatePreviousTabBar to LabShell

User-facing changes

Users can now move though different panels using Ctrl Shift . to go the the next tab bar and Ctrl Shift , to go to the previous. There are also commands in the menu and command palette.

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 20, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@afshin afshin left a comment

I am 👍 on the implementation. I just want to tag @tgeorgeux to ask if we have any heuristic or convention about which keyboard shortcut to use for a command. Is this good to go on that front, too?

@afshin afshin changed the title added commands to move to next/prev tab bar in shell Add commands to move to next/prev tab bar in shell Dec 30, 2019
@afshin afshin added this to the 2.0 milestone Dec 30, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Dec 30, 2019

Looks like vs code has a command (workbench.action.navigateEditorGroups) to cycle between tab bars, but does not assign it a default keyboard shortcut: https://code.visualstudio.com/docs/getstarted/keybindings#_editorwindow-management

@tgeorgeux
Copy link
Contributor

@tgeorgeux tgeorgeux commented Dec 30, 2019

Firefox uses Ctrl+Page Up(left)/Page Down(right) or Cmd+Option+Left/Right. Chrome uses Ctrl+Tab, and Ctrl+Shift+Tab.

I think Ctrl Shift ./, is a great choice! It gives the user arrows to denote directions and mirrows the Ctrl Shift that advances tabs. @qntnrbns

@tgeorgeux tgeorgeux merged commit fbaf591 into jupyterlab:master Dec 30, 2019
10 checks passed
@qntnrbns qntnrbns deleted the feature/activate-tab-bar branch Jan 1, 2020
@lock lock bot added the status:resolved-locked label Jan 31, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants