Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve race condition between default file browser and tree URLs. #7676

Merged
merged 9 commits into from Dec 23, 2019

Conversation

afshin
Copy link
Member

@afshin afshin commented Dec 21, 2019

References

Fixes #4009

Code changes

  • Fix unrelated issue in titleCase function where it fails if null or undefined is passed in at runtime.
  • Fix race condition between default file browser and tree handler. (#4009)
  • The default file browser hides its listing until it is restored.

User-facing changes

The default file browser hides its listing until it is restored.

file-browser

Backwards-incompatible changes

N/A

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 21, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@afshin afshin added this to the 2.0 milestone Dec 21, 2019
@afshin afshin changed the title [WIP] Resolve race condition between default filebrowser and tree handler. Resolve race condition between default file browser and tree URLs. Dec 23, 2019
Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 8ebef8b into jupyterlab:master Dec 23, 2019
10 checks passed
@lock lock bot added the status:resolved-locked label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:application pkg:coreutils pkg:filebrowser status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants