Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ensure-max-old-space now that node 12+ has better default memory ceilings #7677

Merged
merged 3 commits into from Dec 23, 2019

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Dec 21, 2019

References

This reverts #7201 as discussed in #7175

Fixes #7675

Code changes

Deletes the ensure-max-old-space script as no longer needed with node 12+.

User-facing changes

Backwards-incompatible changes

We no longer default to 4G max of memory space. In node 12+, the max memory is set automatically, and for earlier node, the user will have to set a NODE_OPTIONS environment variable.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 21, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 2.0 milestone Dec 21, 2019
Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 6d92e69 into jupyterlab:master Dec 23, 2019
10 checks passed
@lock lock bot added the status:resolved-locked label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Nov 4, 2020

This was reverted in #8083

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants