Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MathJax CDN in the cell and console examples #7680

Merged
merged 1 commit into from Dec 23, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Dec 22, 2019

Code changes

This fixes the following warning when running the cell and console examples:

WARNING: cdn.mathjax.org has been retired. Check https://www.mathjax.org/cdn-shutting-down/ for migration tips.

This change updates the url for the CDN, following the recommendation from https://www.mathjax.org/cdn-shutting-down/.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 22, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio jtpio force-pushed the examples-mathjax-cdn branch from 69561b8 to 1c34a4c Compare Dec 22, 2019
@@ -2,11 +2,11 @@
<html lang="en">
<head>
<title>Cell Demo</title>
<script type="text/javascript" src="https://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS_CHTML-full,Safe&amp;delayStartupUntil=configured"></script>
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.1/MathJax.js?config=TeX-AMS_CHTML-full,Safe&amp;delayStartupUntil=configured"></script>
Copy link
Contributor

@jasongrout jasongrout Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like 2.7.7 is the latest 2.x release. Might as well move to the latest, if not to 3.0?

Copy link
Member Author

@jtpio jtpio Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to bump to 2.7.7 👍

For 3.0, maybe it could be done as part of #7218?

@jasongrout jasongrout added this to the 2.0 milestone Dec 23, 2019
@jtpio jtpio force-pushed the examples-mathjax-cdn branch from 1c34a4c to 1f13139 Compare Dec 23, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Dec 23, 2019

Thanks!

@blink1073 blink1073 merged commit bec5dc8 into jupyterlab:master Dec 23, 2019
8 of 10 checks passed
@jtpio jtpio deleted the examples-mathjax-cdn branch Dec 23, 2019
@lock lock bot added the status:resolved-locked label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked tag:Examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants