Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coreutils split #7681

Merged
merged 13 commits into from Dec 23, 2019
Merged

Coreutils split #7681

merged 13 commits into from Dec 23, 2019

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Dec 22, 2019

References

Closes #7615.

Code changes

Separates out nbformat, the setting registry and statedb + associated code into separate packages.

User-facing changes

None.

Backwards-incompatible changes

Separates out nbformat and the setting registry into separate packages.

Notes:

This wil lupdate the list in #7615 to become (moved, kept)

  • ActivityMonitor
  • DataConnector / IDataConnector (moved to statedb package)
  • Debouncer (being moved to Lumino)
  • DefaultSchemaValidator / ISchemaValidator (moved to settingregistry package)
  • IChangedArgs (pure typings)
  • MarkdownCodeBlocks
  • nbformat (moved to nbformat package)
  • PageConfig
  • PathExt
  • Poll / IPoll (being moved to Lumino)
  • RateLimiter / IRateLimiter (being moved to Lumino)
  • RestorablePool (IObjectPool, IRestorable, IRestorer) (moved to statedb package)
  • SettingRegistry / ISettingRegistry / Settings (moved to settingregistry package)
  • StateDB / IStateDB (moved to statedb package)
  • Text
  • Throttler (being moved to Lumino)
  • Time
  • URLExt

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 22, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@vidartf
Copy link
Member Author

@vidartf vidartf commented Dec 22, 2019

Note: This builds on #7657 in order to try to avoid too many conflicts.

@vidartf
Copy link
Member Author

@vidartf vidartf commented Dec 22, 2019

I saw the error in CI JS locally as well, but fixed that by doing a fresh install. Does Azure cache any files?

@blink1073 blink1073 added this to the 2.0 milestone Dec 23, 2019
Copy link
Member

@blink1073 blink1073 left a comment

Nice, thanks!

@blink1073 blink1073 merged commit 7fb0185 into jupyterlab:master Dec 23, 2019
8 of 10 checks passed
@vidartf vidartf deleted the coreutils-split branch Dec 25, 2019
@lock lock bot added the status:resolved-locked label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants