Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade yarn in staging to 1.21.1 #7691

Merged
merged 3 commits into from Dec 30, 2019
Merged

Upgrade yarn in staging to 1.21.1 #7691

merged 3 commits into from Dec 30, 2019

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Dec 24, 2019

References

The latest yarn bump in the root package.json to 1.21.1 did not actually upgrade the yarn we ship.

Fixes #7692

Code changes

This upgrades the yarn we ship to yarn 1.21.1, using the distribution file https://github.com/yarnpkg/yarn/releases/download/v1.21.1/yarn-1.21.1.js (from the release notes https://github.com/yarnpkg/yarn/releases/tag/v1.21.1)

User-facing changes

Backwards-incompatible changes

The latest yarn bump in the root package.json to 1.21.1 did not actually upgrade the yarn we ship.

This upgrades the yarn we ship to yarn 1.21.1, using the distribution file https://github.com/yarnpkg/yarn/releases/download/v1.21.1/yarn-1.21.1.js (from the release notes https://github.com/yarnpkg/yarn/releases/tag/v1.21.1)
@jasongrout jasongrout added this to the 2.0 milestone Dec 24, 2019
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 24, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

We deleted the yarn.lock, the ran `jlpm install`, then `jlpm run deduplicate`.
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Dec 24, 2019

@blink1073 - I think this should be merged before the next beta release.

@telamonian
Copy link
Member

@telamonian telamonian commented Dec 26, 2019

The latest yarn bump in the root package.json to 1.21.1 did not actually upgrade the yarn we ship.

I noticed this as well, and wondered what the deal was. Thanks for tackling it

Copy link
Member

@telamonian telamonian left a comment

LGTM!

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Dec 30, 2019

Thanks @telamonian. @afshin, you were merging things recently. Is there a reason you didn't merge this?

@afshin
Copy link
Member

@afshin afshin commented Dec 30, 2019

No, I just got caught up in other tasks!

@afshin
Copy link
Member

@afshin afshin commented Dec 30, 2019

(And I was only looking at the PRs with green checkboxes and didn't re-run these to see if they pass.)

afshin
afshin approved these changes Dec 30, 2019
Copy link
Member

@afshin afshin left a comment

Cheers!

👍

@afshin afshin merged commit 8fbb4ff into jupyterlab:master Dec 30, 2019
10 checks passed
@lock lock bot added the status:resolved-locked label Jan 30, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
@jasongrout jasongrout deleted the yarnup branch Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants