Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more careful about sessioncontext kernelChanged and sessionChanged signal emissions #7694

Merged
merged 3 commits into from Dec 29, 2019

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Dec 24, 2019

References

Fixes #7690 and #7693

Code changes

Emit the session and kernel changed signals when needed, like when the connection is disposed. Also use sessioncontext path/name for console tracker restoration.

User-facing changes

Fixes #7690, showing the kernel status correctly.

Backwards-incompatible changes

No APIs were changed.

@jasongrout jasongrout added this to the 2.0 milestone Dec 24, 2019
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 24, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

jasongrout added 2 commits Dec 24, 2019
…refresh.

Before, the save would happen before the session was created, which meant that the args values would be undefined, so new consoles would be created on refresh, plus the existing sessions would be displayed, doubling the number of consoles every refresh.

Fixes jupyterlab#7693
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Dec 24, 2019

@blink1073 - this fixes some pretty bad bugs and I think should be in the next beta.

afshin
afshin approved these changes Dec 29, 2019
Copy link
Member

@afshin afshin left a comment

Thanks!
👍

@afshin afshin merged commit 1fc7a3d into jupyterlab:master Dec 29, 2019
10 checks passed
@lock lock bot added the status:resolved-locked label Jan 28, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants