Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default file browser manually. #7695

Merged
merged 2 commits into from Jan 2, 2020
Merged

Conversation

afshin
Copy link
Member

@afshin afshin commented Dec 24, 2019

References

Fixes #4009

Code changes

Uses the auto parameter of the file browser model Poll to prevent it from loading the default file browser before it has been restored.

User-facing changes

N/A, but page loading is faster for /tree URLs.

Backwards-incompatible changes

N/A

cc: @timkpaine, finally 馃槍

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 24, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@afshin afshin self-assigned this Dec 24, 2019
@afshin afshin added this to the 2.0 milestone Dec 24, 2019
Copy link
Member

@blink1073 blink1073 left a comment

LGTM, thanks!

@blink1073 blink1073 merged commit 35cdd43 into jupyterlab:master Jan 2, 2020
10 checks passed
@lock lock bot added the status:resolved-locked label Feb 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:filebrowser status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants