Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Tracker from MainAreaWidget back to ConsolePanel #7705

Merged
merged 4 commits into from Jan 3, 2020

Conversation

KsavinN
Copy link
Contributor

@KsavinN KsavinN commented Dec 27, 2019

References

Fixes #7648. Fixes #7726

Code changes

Back to ConsolePanel Tracker. ConsolePanel now is extended by MainAreaWidget, have access to toolbar and content as NotebookPanel.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 27, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@KsavinN KsavinN force-pushed the 7648-issue branch 2 times, most recently from 6032d86 to 7c90ac5 Compare Dec 30, 2019
@KsavinN KsavinN marked this pull request as ready for review Dec 30, 2019
@KsavinN KsavinN changed the title [WIP] Change Tracker from MainAreaWidget back to ConsolePanel Change Tracker from MainAreaWidget back to ConsolePanel Dec 31, 2019
@afshin afshin self-requested a review Jan 1, 2020
@afshin afshin added this to the 2.0 milestone Jan 1, 2020
@afshin afshin changed the title Change Tracker from MainAreaWidget back to ConsolePanel [WIP] Change Tracker from MainAreaWidget back to ConsolePanel Jan 1, 2020
@afshin
Copy link
Member

@afshin afshin commented Jan 1, 2020

Thanks @KsavinN! I pushed these two changes to your PR:

  • Removed the content instantiation option and directly create it in the super(...) call.
  • Changed isActivate back to activate because the option is meant to signal "whether to activate the console", which is an action, not a state.

But this one is still broken. I will take a look later, but if it isn't done by Thursday, we can look at it together, perhaps.

  • The console does not restore itself.

Copy link
Member

@afshin afshin left a comment

The console restoration logic is broken. Everything else is 👍

@afshin afshin changed the title [WIP] Change Tracker from MainAreaWidget back to ConsolePanel Change Tracker from MainAreaWidget back to ConsolePanel Jan 3, 2020
afshin
afshin approved these changes Jan 3, 2020
@blink1073
Copy link
Member

@blink1073 blink1073 commented Jan 3, 2020

Thanks!

@blink1073 blink1073 merged commit 736503e into jupyterlab:master Jan 3, 2020
10 checks passed
@lock lock bot added the status:resolved-locked label Feb 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
3 participants