Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach update-dependency about more range specifiers and make it adopt the current range for any tag #7709

Merged
merged 1 commit into from Jan 2, 2020

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Dec 30, 2019

References

Follows up on #7590 and fixes a bug there.

Code changes

Currently there is a special case to adopt the existing range specifier if the upgraded range is ‘latest’. This extends this special case for any upgrade to a tag version. This also allows for range specifiers of =, <, >, <=, and >=.

This fixes a bug where updating to ^latest generates a spec of ^^latest in the current version.

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Dec 30, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

… the current range for any tag.

Currently there is a special case to adopt the existing range specifier if the upgraded range is ‘latest’. This extends this special case for any upgrade to a tag version. This also allows for range specifiers of =, <, >, <=, and >=.

This fixes a bug where updating to ^latest generates a spec of ^^latest in the current version.
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Dec 31, 2019

CC @lresende

@jasongrout jasongrout added this to the 2.0 milestone Dec 31, 2019
@blink1073
Copy link
Member

@blink1073 blink1073 commented Jan 2, 2020

Thanks!

@blink1073 blink1073 merged commit 2648e13 into jupyterlab:master Jan 2, 2020
10 checks passed
@lock lock bot added the status:resolved-locked label Feb 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants