Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up UX of property inspector #7718

Merged
merged 1 commit into from Jan 3, 2020

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Jan 2, 2020

References

Fixes #7686
image

Code changes

Cleans up the CSS for property inspector children.

User-facing changes

Notebook tools are now rendered properly.

Backwards-incompatible changes

None.

@blink1073 blink1073 added this to the 2.0 milestone Jan 2, 2020
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jan 2, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

afshin
afshin approved these changes Jan 3, 2020
Copy link
Member

@afshin afshin left a comment

Cheers!

👍

@afshin afshin merged commit 319f179 into jupyterlab:master Jan 3, 2020
10 checks passed
@lock lock bot added the status:resolved-locked label Feb 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2020
@blink1073 blink1073 deleted the fix-property-inspector branch Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants