Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address todos and deprecations for 2.0 #7724

Merged
merged 9 commits into from Jan 4, 2020

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Jan 2, 2020

References

Partially addresses #7720

Code changes

Remove deprecations and implement some TODOs for 2.0.

User-facing changes

None

Backwards-incompatible changes

Some deprecation warnings are implemented. The signature of our commands functions has been simplified.

@blink1073 blink1073 added this to the 2.0 milestone Jan 2, 2020
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jan 2, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 changed the title address todos and deprecations for 2.0 Address todos and deprecations for 2.0 Jan 2, 2020
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jan 3, 2020

@jasongrout, are you able to review this one?

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jan 3, 2020

@telamonian, same question. I'd like to include this in the beta today.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jan 3, 2020

I can review this tomorrow, but not today.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jan 3, 2020

(I'm happy to do the beta release tomorrow as well, if it turns out that I need to review this tomorrow)

Copy link
Member

@telamonian telamonian left a comment

LGTM! Looks like some nice cleanup and reasonable deletions

packages/notebook/src/panel.ts Show resolved Hide resolved
@blink1073 blink1073 merged commit c936a77 into jupyterlab:master Jan 4, 2020
10 checks passed
@blink1073 blink1073 mentioned this pull request Jan 8, 2020
23 tasks
@lock lock bot added the status:resolved-locked label Feb 3, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2020
@blink1073 blink1073 deleted the address-todos branch Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants