Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of linked extensions #7728

Merged
merged 1 commit into from Jan 6, 2020

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Jan 3, 2020

References

Fixes #6738

Code changes

Uses resolutions for linked extensions and packages, so they do not need to be published to npm. Also cleans up the handling of the creation of the packages in staging/linked_packages, which was sometimes resulting in the file not being populated there.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jan 3, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 2.0 milestone Jan 3, 2020
@lresende
Copy link
Member

@lresende lresende commented Jan 4, 2020

@ajbozarth

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jan 6, 2020

Looks like it should work to me. Thanks!

@jasongrout jasongrout merged commit 84ec48a into jupyterlab:master Jan 6, 2020
10 checks passed
@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jan 8, 2020

cc @kgryte this should help with our linked extensions issue we were having in datastore and remove need for verdaccio

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jan 16, 2020

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Jan 16, 2020
blink1073 pushed a commit that referenced this issue Jan 16, 2020
…8-on-1.x

Backport PR #7728 on branch 1.x (Fix handling of linked extensions)
@lock lock bot added the status:resolved-locked label Feb 16, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 16, 2020
@blink1073 blink1073 deleted the linked-extension-check branch Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked tag:Build System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants