Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update state database list method to query based on namespace match. #7742

Merged
merged 4 commits into from Jan 5, 2020

Conversation

afshin
Copy link
Member

@afshin afshin commented Jan 5, 2020

References

Fixes #7257.

Code changes

Instead of checking that the key starts with the sub-string query, the state database connector checks for explicit namespace string match.

User-facing changes

N/A

Backwards-incompatible changes

The previous behavior could generate false positives. This fixes that bug, but since the behavior is different, it's possible a client relied on the old behavior. I hope that is unlikely, though.

@afshin afshin added this to the 2.0 milestone Jan 5, 2020
@afshin afshin self-assigned this Jan 5, 2020
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jan 5, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 0909afa into jupyterlab:master Jan 5, 2020
10 checks passed
@lock lock bot added the status:resolved-locked label Feb 4, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:statedb status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants