Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Font Awesome to 5.12 #7769

Merged
merged 1 commit into from Jan 10, 2020
Merged

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jan 10, 2020

References

This PR takes over #7754 and is related to jupyter-widgets/ipywidgets#2698

Code changes

Upgrade Font Awesome to 5.12

Backwards-incompatible changes

This should no be backwards-incompatible as we include the v4-shim CSS which adds support for v4 class names in v5.

Signed-off-by: martinRenou <martin.renou@gmail.com>
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jan 10, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@martinRenou
Copy link
Member Author

@martinRenou martinRenou commented Jan 10, 2020

I wonder if the CI error is related, I don't really get the error message

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jan 10, 2020

I wonder if the CI error is related, I don't really get the error message

Not likely. That test fails a lot on windows.

I'll leave this open for a day for anybody else to chime in. If there are no objections, I'll merge. I think it's a great idea to update fontawesome.

@jasongrout jasongrout added this to the 2.0 milestone Jan 10, 2020
Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 57cd454 into jupyterlab:master Jan 10, 2020
10 checks passed
@martinRenou martinRenou deleted the upgrade_fontawesome branch Jan 10, 2020
@lock lock bot added the status:resolved-locked label Feb 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:application status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants