Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to setting editor should trigger application dirty state #7774

Merged
merged 1 commit into from Jan 13, 2020

Conversation

Madhu94
Copy link
Collaborator

@Madhu94 Madhu94 commented Jan 12, 2020

References

Fixes #7757

Code changes

In settingEditor extension, when the status of the commands (revert, save) change, I check if the editor has unsaved changes (using the property editor.canSaveRaw). If this is set to true, LabStatus.setDIrty is invoked. If set to false, the dirty status is cleared.

User-facing changes

Closing / reloading lab when there are unsaved changes in the settings editor would warn of unsaved changes and ask if the user should .

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jan 12, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 2.0 milestone Jan 13, 2020
Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 2ee8ef2 into jupyterlab:master Jan 13, 2020
8 of 10 checks passed
@lock lock bot added the status:resolved-locked label Feb 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants