Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove removing ws #7780

Merged
merged 3 commits into from Jan 14, 2020
Merged

remove removing ws #7780

merged 3 commits into from Jan 14, 2020

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Jan 13, 2020

This hopefully fixes issue #6934 which is really puzzling to developers as ws stays undefined without this shim. Many thirdparty libraries just import ws and are done, so not just undefining ws is important (I am listing some workarounds and examples in the issue).

It would be great if we could get this into 2.0 ...

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jan 13, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Contributor

@jasongrout jasongrout left a comment

Wolf and I talked through this, and it looks good to me. Thanks Wolf!

@jasongrout jasongrout merged commit 6111f2b into jupyterlab:master Jan 14, 2020
8 of 10 checks passed
@jasongrout jasongrout added this to the 2.0 milestone Jan 14, 2020
@lock lock bot added the status:resolved-locked label Feb 13, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:services status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants