Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for center-aligned images with IPython.display.Image #7798

Merged
merged 1 commit into from Jan 20, 2020

Conversation

agbaum
Copy link
Contributor

@agbaum agbaum commented Jan 18, 2020

References

#7752

Code changes

Changed the margins from auto to 0 for image rendering in rendermime.

User-facing changes

Changes the alignment of images from IPython.display.Image when embed=False

Before:
Before

After:
After

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jan 18, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 2.0 milestone Jan 20, 2020
Copy link
Member

@blink1073 blink1073 left a comment

Looks good to me, thank you! And congratulations on your first contribution to JupyterLab!

@blink1073 blink1073 merged commit c1a277c into jupyterlab:master Jan 20, 2020
10 checks passed
@lock lock bot added the status:resolved-locked label Feb 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:rendermime status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants