Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed refresh issue for html viewer(slides)-7552 #7824

Merged
merged 1 commit into from Jan 28, 2020

Conversation

ggbhat
Copy link
Member

@ggbhat ggbhat commented Jan 25, 2020

References
Fix for #7552

Code changes
As @jasongrout suggested added dirty check and reload from disk instead of just reassigning the content url for iframe in htmlviewer.
Also added dirty check for reload from disk logic so that confirmation dialog will be shown only if the current context model is dirty.

User-facing changes
None.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jan 25, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 6433521 into jupyterlab:master Jan 28, 2020
10 checks passed
@jasongrout jasongrout removed this from the 2.0 milestone Jan 30, 2020
@jasongrout jasongrout added this to the 2.1 milestone Jan 30, 2020
@jasongrout jasongrout removed this from the 2.1 milestone Feb 24, 2020
@jasongrout jasongrout added this to the 2.0 milestone Feb 24, 2020
@lock lock bot added the status:resolved-locked label Mar 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:docmanager pkg:htmlviewer status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants